Require use of trailing commas at declaration site #4760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manodnyab
reviewed
Aug 6, 2024
| @@ -436,7 +436,8 @@ class CawsConnectionProvider : GatewayConnectionProvider { | |||
| } | |||
|
|
|||
| is GitSettings.CawsOwnedRepoSettings, | |||
| is GitSettings.NoRepo -> { | |||
| is GitSettings.NoRepo, | |||
There was a problem hiding this comment.
is this the correct syntax, do we want the comma here?
There was a problem hiding this comment.
yes it is multi line so it makes sense
manodnyab
approved these changes
Oct 2, 2024
rli
force-pushed
the
rli/require-trailing-commas-declaration
branch
from
9452d98 to
f224b7b
Compare
rli
force-pushed
the
rli/require-trailing-commas-declaration
branch
from
f224b7b to
c9b7809
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://kotlinlang.org/docs/coding-conventions.html#trailing-commas
Requiring trailing commas at call site would be nice as well, but will revisit in the future
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.